011ReviewmidPython / Django Admin真实来源改编 Django
Django Admin：readonly JSONField 展示为合法 JSON
审查 Django admin 的一个展示层补丁：作者让详情页 readonly 的 JSONField 走字段自身的序列化逻辑，以 JSON 文本展示，而不是 Python repr。
@@ -398,6 +398,13 @@ def display_for_field(value, field, empty_value_display): return formats.number_format(value) elif isinstance(field, models.FileField) and value: return format_html('<a href="{}">{}</a>', value.url, value)+ elif isinstance(field, models.JSONField) and value:+ try:+ return field.get_prep_value(value)+ except TypeError:+ # Unserializable values fall back to the generic display path+ # instead of breaking the change page.+ return display_for_value(value, empty_value_display) else: return display_for_value(value, empty_value_display) @@ -179,6 +179,9 @@ class UtilsTests(SimpleTestCase): display_value = display_for_field(None, models.FloatField(), self.empty_value) self.assertEqual(display_value, self.empty_value) + display_value = display_for_field(None, models.JSONField(), self.empty_value)+ self.assertEqual(display_value, self.empty_value)+ def test_number_formats_display_for_field(self): display_value = display_for_field(12345.6789, models.FloatField(), self.empty_value) self.assertEqual(display_value, '12345.6789')@@ -227,6 +230,20 @@ class UtilsTests(SimpleTestCase): display_value = display_for_field(value, models.FloatField(), self.empty_value) self.assertEqual(display_value, '12345.6789') + def test_json_display_for_field(self):+ tests = [+ ({'a': {'b': 'c'}}, '{"a": {"b": "c"}}'),+ (['a', 'b'], '["a", "b"]'),+ ('a', '"a"'),+ ({('a', 'b'): 'c'}, "{('a', 'b'): 'c'}"), # Invalid JSON.+ ]+ for value, display_value in tests:+ with self.subTest(value=value):+ self.assertEqual(+ display_for_field(value, models.JSONField(), self.empty_value),+ display_value,+ )+ def test_list_display_for_value(self): display_value = display_for_value([1, 2, 3], self.empty_value) self.assertEqual(display_value, '1, 2, 3')