018ReviewseniorPython / xarray + dask真实来源改编 xarray

xarray：更新 Dataset 时处理 DataArray tuple 输入

审查一个 xarray PR：作者在 tuple 输入中把 DataArray 转成 ndarray，以避免 Variable 构造的歧义。

diff --git a/xarray/core/variable.py b/xarray/core/variable.py@@     elif isinstance(obj, tuple):+        if isinstance(obj[1], DataArray):+            # Avoid ambiguous DataArray construction by materializing values.+            obj = (obj[0], np.asarray(obj[1]), *obj[2:])         try:             obj = Variable(*obj)@@+def test_update_dataarray_tuple_values_equal():+    ds.update({'foo': (('x', 'y'), chunked_da)})+    assert_array_equal(ds.foo.values, chunked_da.values)

PR 说明codegen-agent · CI passed

Normalize DataArray tuple payloads before constructing Variables

Dataset.update can receive variables in tuple form, but passing a DataArray as the tuple payload is ambiguous because Variable expects raw data rather than another labeled array object.

This PR normalizes tuple payloads by converting DataArray values with np.asarray before calling Variable(*obj). That gives Variable a plain ndarray and keeps the update path consistent with NumPy-backed inputs.

Added a regression test that updates a Dataset with a chunked DataArray tuple and checks the resulting values are equal. Existing xarray tests pass.

背景3 条

xarray DataArray can wrap NumPy arrays or dask arrays. Dask-backed arrays preserve lazy evaluation and chunk metadata.

Dataset.update should preserve the underlying data semantics when possible; reading .values or forcing np.asarray can materialize lazy arrays.

The review context includes the pre-patch tuple-to-Variable conversion excerpt in src-variable.py.