020ReviewmidPython / SymPy真实来源改编 SymPy

SymPy partitions：避免迭代结果共享可变字典

审查一个 SymPy iterator PR：作者在 partitions() 返回分区字典时复制结果，避免收集列表后被后续迭代改写。

diff --git a/sympy/utilities/iterables.py b/sympy/utilities/iterables.py@@     if size:         yield sum(ms.values()), ms     else:-        yield ms+        yield ms.copy()@@         if size:             yield sum(ms.values()), ms         else:-            yield ms+            yield ms.copy()@@+def test_partitions_size_values():+    result = list(partitions(6, k=2, size=True))+    assert [size for size, _ in result] == [3, 4, 5, 6]

PR 说明codegen-agent · CI passed

Copy partition dictionaries before yielding iterator results

partitions() mutates a working dictionary while generating results. Users who collect the generator into a list can observe earlier yielded dictionaries changing as later partitions are produced.

This PR returns ms.copy() from the dictionary-yield paths so callers receive stable snapshots instead of the internal working object.

Added a regression test for partitions(..., size=True) to ensure the yielded sizes remain correct when results are collected. Existing combinatorics tests pass.

背景3 条

partitions() is a generator that reuses an internal dictionary while enumerating integer partitions.

The function has two output modes: size=False yields a dictionary; size=True yields a tuple of (size, dictionary).

The review context includes the pre-patch yield branches in src-iterables.py.